Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/oasis-node/cmd/node: Do not allow running oasis-node as root #4559

Merged
merged 1 commit into from
Mar 16, 2022
Merged

go/oasis-node/cmd/node: Do not allow running oasis-node as root #4559

merged 1 commit into from
Mar 16, 2022

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Mar 10, 2022

Fixes #4464

@Yawning Yawning force-pushed the yawning/feature/4464 branch 2 times, most recently from e6fbc23 to e45be68 Compare March 10, 2022 17:08
@codecov
Copy link

codecov bot commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #4559 (e45be68) into master (c4bb133) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

❗ Current head e45be68 differs from pull request most recent head 45e6541. Consider uploading reports for the commit 45e6541 to get more accurate results

@@            Coverage Diff             @@
##           master    #4559      +/-   ##
==========================================
- Coverage   67.08%   67.05%   -0.03%     
==========================================
  Files         424      425       +1     
  Lines       47955    47977      +22     
==========================================
+ Hits        32171    32172       +1     
- Misses      11861    11862       +1     
- Partials     3923     3943      +20
Impacted Files Coverage Δ
go/oasis-node/cmd/node/node.go 54.41% <57.14%> (-1.59%) ⬇️
go/oasis-node/cmd/common/common.go 58.74% <100.00%> (+1.18%) ⬆️
go/oasis-node/cmd/common/flags/flags.go 95.34% <100.00%> (+0.61%) ⬆️
go/oasis-node/cmd/ias/proxy.go 49.63% <100.00%> (+0.37%) ⬆️
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/apps/beacon/genesis.go 63.63% <0.00%> (-6.07%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
go/runtime/host/protocol/connection.go 69.17% <0.00%> (-3.01%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec4094...45e6541. Read the comment docs.

@Yawning Yawning force-pushed the yawning/feature/4464 branch 5 times, most recently from 4aee938 to 5a33048 Compare March 16, 2022 09:28
@Yawning Yawning enabled auto-merge March 16, 2022 09:42
@Yawning Yawning force-pushed the yawning/feature/4464 branch from 5a33048 to 45e6541 Compare March 16, 2022 10:45
@Yawning Yawning merged commit 59d58e8 into master Mar 16, 2022
@Yawning Yawning deleted the yawning/feature/4464 branch March 16, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@abukosek abukosek abukosek approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oasis-node should refuse to run if uid/euid is 0
3 participants
@Yawning @kostko @abukosek